Conversation
I do not sure that I will understand whole impact on the EMCC modularization, but at least these fixes in the modularization works for me in the Blazor applciation, which is by itself ESM environment. closes sql-js#524
Author
|
@lovasoa can you take a look again? |
Member
|
Hi and thank you for the contribution! This looks like this duplicates existing code, doesn't it? Maybe the best place for a fix is inside emscripten itself? |
Author
|
I’m Windows developer by heart. I really would like to help, but because of one my quirk where I love to have native Windows build for everything I may go down to very deep rabbit hole. Given that I have no idea what’s an issue with Emscripten you are mention in comment, my second fear is that go down that route and dont come back. I may pinky swear that I will try that and come back within week, but if not I would appreciate if you merge this as is. Will this work for you? Or maybe you have other ideas how we can solve that? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I do not sure that I will understand whole impact on the EMCC modularization, but at least these fixes in the modularization works for me in the Blazor applciation, which is by itself ESM environment.
closes #524